Remove CCW vtable logic from ABI interfaces which don't need them #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faces unless they are overridable as we do not generate CCW for them.
j0shuams
reviewed
Jul 11, 2022
j0shuams
reviewed
Jul 11, 2022
j0shuams
reviewed
Jul 11, 2022
j0shuams
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we generate the CCW vtable logic for all interfaces. But we really only need them for non-exclusive interfaces that can be implemented by managed objects, C# authored interfaces, and overridable exclusive interfaces on unsealed types. For all the other interfaces (exclusive interfaces that aren't overridable), we do not need to generate the CCW vtable logic which can result in DLL size reductions.