Some QoL improvements for diag tests #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
asklar
commented
Jun 15, 2022
•
asklar
commented
- Fixes DiagnosticTests! There were a few non-passing tests so I debugged into it and saw that we're failing because in some codepaths we didn't have an assembly name or version. Passing these requires a context options object.
- DiagnosticTests can now pass a context with options, so we can remove special casing we had for cswinrt generator when running inside a test host
- When tests failed, the inner exception was not being captured, so the error just said "...But found:" and no additional information about the exception in the generator was provided
- Setting ExitCode upon error, which should cause builds to fail when the generator fails to produce. Fixes Build succeeds even when generator fails #1202
- Fixes some typos
manodasanW
reviewed
Jun 16, 2022
| @@ -154,6 +152,7 @@ public void Generate() | |||
| { | |||
| Logger.Log("Exiting early -- found errors in authored runtime component."); | |||
| Logger.Close(); | |||
| Environment.ExitCode = -1; | |||
There was a problem hiding this comment.
Didn't realize we can do this, does this make the build fail out and how does it look like when it does?
j0shuams
approved these changes
Jun 27, 2022
asklar
force-pushed
the
diagtestContextOptions
branch
from
7b13929 to
e98230b
Compare
j0shuams
approved these changes
Aug 3, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.