Add public option to embedded support for enums #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
May 10, 2022
manodasanW
reviewed
May 10, 2022
| @@ -11,6 +11,8 @@ | |||
| <CsWinRTWindowsMetadata>10.0.19041.0</CsWinRTWindowsMetadata> | |||
| <SimulateCsWinRTNugetReference>true</SimulateCsWinRTNugetReference> | |||
| <CsWinRTGenerateProjection>true</CsWinRTGenerateProjection> | |||
| <!-- Will expose enums as public in the projection | |||
There was a problem hiding this comment.
Do we want a test or something for this option?
There was a problem hiding this comment.
I think it's fine to leave testing this particular case to manual testing. We'd need another library for the different projection, plus the bells and whistles. I think the impact of these changes is low enough to not warrant such additional testing infrastructure.
manodasanW
approved these changes
May 10, 2022
j0shuams
force-pushed
the
jlarkin/embedded-public-enums
branch
from
8de9055 to
d4d23ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to enable PowerShell's AppX module, we found that some of the commands shipped within the module have options. These command line options are based on projected enum values, and the existing embedded support made those enums private to the module. There's no harm in exposing enums since they're simple objects, so we support public enums now.