Pack project PRI next to WinMD #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: C++ and C# apps that use nuget references to authored components work with custom user controls. |
manodasanW
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, C++ apps that try to use XAML/WinUI types authored with C#/WinRT fail at runtime because they can't find the xaml resources.
E.g.
WinRT originate error - 0x80004005 : 'Cannot locate resource from 'ms-appx:///WinUIComponentCs/NameReporter.xaml'.'.Evelyn and I found that the component's PRI file needs to live in same folder as the WinMD.
This PR updates our build logic to reflect this requirement.
Fixes #1118
We're taking advantage of msbuild here actually. Since the pri file has the same name as the winmd and the winmd is a reference assembly, msbuild will grab the pri. It's not just for PRI, PRI is one of the allowed extensions for this behavior.