Correctly resolve WinRT.Runtime.dll in Authoring targets #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced some de-duplication logic in our authoring targets that work to isolate the latest version of WinRt.Runtime and use it when building components. In this we assumed CsWinRT nupkg would always be available, so the WinRT.Runtime from the lib folder would be comparable. But we hit a WinUI failure where this wasn't the case, because the dotnet/sdk is doing its own de-duplication. We resolve this by removing our de-duplication logic, in favor of the dotnet/sdk's.
Fixes #1156
After we get this in, we will need to remove the workaroud in WinUI.