Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MarshalGeneric use ObjectReferenceValue and remove MarshalArray2 #1132

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

manodasanW
Copy link
Member

  • MarshalArray2 is actually not needed as we can just update the implementation. To avoid that API addition, removing it before our release.
  • Updated generic marshalers to use ObjectReferenceValue but boxing makes it such that it doesn't get as much perf improvements as the non generic marshaler scenario.
  • Remove potential race in setting and reading guid value as it is not atomic set.
  • Reduce the # of funcs created by moving common ones outside of the generic class which was previously causing them to JIT each time.
  • Update agile reference to also accept ObjectReferenceValue since we are updating the generic marshalers.

@manodasanW manodasanW merged commit ba56eda into master Mar 12, 2022
@manodasanW manodasanW deleted the manodasanw/marshalgenericpart2 branch March 12, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants