Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve non agile object performance #1106

Merged
merged 8 commits into from
Feb 16, 2022

Conversation

manodasanW
Copy link
Member

This change brings in Joshua's change 3122ce1 for removing uses of Lazy in ObjectReferenceWithContext and adds some benchmarks and a couple other improvements in agile references which are used in ObjectReferenceWithContext.

Master

Method Mean Error StdDev Allocated
ConstructAndQueryNonAgileObject 15.74 ms 0.287 ms 0.341 ms 8 KB
ConstructNonAgileObject 15.70 ms 0.285 ms 0.292 ms 3 KB

PR

Method Mean Error StdDev Allocated
ConstructAndQueryNonAgileObject 15.74 ms 0.309 ms 0.289 ms 5 KB
ConstructNonAgileObject 15.79 ms 0.161 ms 0.151 ms 2 KB

Overall the perf difference is within the error range, but we do reduce allocations which can be helpful with reducing GC time spent later.

@manodasanW manodasanW merged commit 25d83dd into master Feb 16, 2022
@manodasanW manodasanW deleted the manodasanw/optimizeobjectrefcontext branch February 16, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants