Change return type of CanExecuteChanged only for MUX.Input.ICommand #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @mcooley - with this change, what does CanExecuteChanged get projected to for Windows.UI.Xaml.Input.ICommand? |
|
@asklar on Windows.UI.Xaml.Input.ICommand, CanExecuteChanged will be |
asklar
approved these changes
Mar 2, 2022
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1092 in repo microsoft/CsWinRT |
|
@manodasanW could you take a look? LGTM. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manodasanW
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597
Microsoft.UI.Xaml.Input.ICommand is mapped to System.Windows.Input.ICommand. The CanExecuteChanged events on those two types aren't exactly the same, so there is a special case in the code generation to fix up the type mapping. This was introduced in #112.
The check for this special case is currently too broad: it will apply to any event named "CanExecuteChanged" of type "EventHandler", even if that event is part of some unknown-to-cswinrt type that is not mapped to System.Windows.Input.ICommand. (I hit this with the WUX.Input.ICommand type in system XAML--since system XAML is not supported, its types should be treated as unknown-to-cswinrt everywhere.)
This PR makes the check more specific, so it affects only the mapped MUX type.