Correct embedded sample #1048
Merged
Correct embedded sample #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some commit rewriting done that I didnt realized had happened when merging up topic branches. And then was missed in code review. But the sample library for embedded support is out of date in master, so this PR updates it. The main issue was in the main of the lib, it was registering the assembly unnecessarily. The rest is cutting unused code.
Also, in the code review we decided to take out some IncludeAssets metadata in the sample, and this was a mistake. We needed that metadata as it prevented runtime assets being resolved when they shouldn't have been.