reduce usage of getruntimeclassname #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Nov 12, 2021
src/Benchmarks/QueryInterface.cs
Outdated
| public object DefaultStringParameters() | ||
| { | ||
| instance.DefaultStringProperty = "Hello"; | ||
| return instance.DefaultObjectProperty; |
There was a problem hiding this comment.
return DefaultStringProperty?
manodasanW
approved these changes
Nov 12, 2021
| @@ -26,7 +26,8 @@ namespace WinRT | |||
| #endif | |||
| static partial class ComWrappersSupport | |||
| { | |||
| private readonly static ConcurrentDictionary<string, Func<IInspectable, object>> TypedObjectFactoryCache = new ConcurrentDictionary<string, Func<IInspectable, object>>(StringComparer.Ordinal); | |||
| private readonly static ConcurrentDictionary<string, Func<IInspectable, object>> TypedObjectFactoryCacheForString = new ConcurrentDictionary<string, Func<IInspectable, object>>(StringComparer.Ordinal); | |||
There was a problem hiding this comment.
ForRuntimeClassName might be more clear?
| @@ -330,25 +331,8 @@ private static bool IsIReferenceArray(Type implementationType) | |||
| Expression.Call(fromAbiMethod, Expression.Property(parms[0], "ThisPtr")), parms).Compile(); | |||
| } | |||
|
|
|||
| internal static Func<IInspectable, object> CreateTypedRcwFactory(string runtimeClassName) | |||
| internal static Func<IInspectable, object> CreateTypedRcwFactory(Type implementationType, string runtimeClassName = "") | |||
There was a problem hiding this comment.
I recall you were considering making the default null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.