Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the FastUpToDateCheck relationship between WinRT.cs and the input winmds. #1026

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Fix the FastUpToDateCheck relationship between WinRT.cs and the input winmds. #1026

merged 2 commits into from
Oct 26, 2021

Conversation

jlaanstra
Copy link
Collaborator

Fixes microsoft/WindowsAppSDK#1525.

Tested:

  • modification of a winmd input causing project to build.
  • modification of WinRT.cs causing project to build.

@jlaanstra
Copy link
Collaborator Author

/cc @drewnoakes

@manodasanW manodasanW requested a review from Scottj1s October 19, 2021 16:45
Scottj1s
Scottj1s approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested a couple scenarios in WinUI-Samples repo, LGTM. thanks Johan!

@manodasanW
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jlaanstra
Copy link
Collaborator Author

tested a couple scenarios in WinUI-Samples repo, LGTM. thanks Johan!

Can you merge? I don't have permissions.

@Scottj1s Scottj1s merged commit db7a841 into microsoft:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scottj1s Scottj1s Scottj1s approved these changes

@drewnoakes drewnoakes drewnoakes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding the WindowsAppSDK to a C# project breaks VS FastUpToDate and causes it to always build.
4 participants
@jlaanstra @manodasanW @drewnoakes @Scottj1s