Fix build with VS2022 #1017
Merged
Fix build with VS2022 #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Oct 11, 2021
| @@ -4922,7 +4922,6 @@ IInspectableVftbl = global::WinRT.IInspectable.Vftbl.AbiToProjectionVftable, | |||
| XLANG_ASSERT(get_category(type) == category::interface_type); | |||
| auto type_name = write_type_name_temp(w, type, "%", typedef_name_type::CCW); | |||
|
|
|||
| uint32_t const vtable_base = type.MethodList().first.index(); | |||
There was a problem hiding this comment.
This is fixing unused variable warning with VS2022.
|
@Scottj1s @manodasanW PTLA Also, I have submitted similar PR to TestWinRT repo: microsoft/TestWinRT#53 |
|
/azp run |
|
No pipelines are associated with this pull request. |
manodasanW
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS2022 has VisualStudioVersion=17.0 that was unhandled in the project files and falling back to VS2015 build tools.
I have fixed this by deleting the fallback to VS2015/2017 build tools since it does not seem to work anyway.