Skip to content

Commit

Permalink
Update dotnet SDK to to address VS 16.10 regressions (#857)
Browse files Browse the repository at this point in the history
* Update .NET SDK

* Remove compilers toolset package to use newer default.

* Update workspaces package version

* Fix one more version.
  • Loading branch information
manodasanW authored Jun 2, 2021
1 parent f84a3d5 commit 806fe82
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0-4.20472.6" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.0" PrivateAssets="all" />
</ItemGroup>

Expand Down
6 changes: 0 additions & 6 deletions src/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
<LangVersion>preview</LangVersion>
<RestoreSources>
https://api.nuget.org/v3/index.json;
https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json;
https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;
https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;
</RestoreSources>
</PropertyGroup>
Expand All @@ -21,10 +19,6 @@
<Compile Condition="'$(GeneratedFilesDir)' != '$(GeneratedFilesRootDir)'" Include="$(GeneratedFilesDir)*.cs" />
</ItemGroup>

<ItemGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'">
<PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="3.8.0-4.20472.6" />
</ItemGroup>

<ItemGroup>
<FrameworkReference Remove="Microsoft.Windows.SDK.NET.Ref" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/DiagnosticTests/DiagnosticTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<PackageReference Include="NUnit" Version="3.12.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0-4.20472.6" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.0" PrivateAssets="all" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/build.cmd
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@echo off
if /i "%cswinrt_echo%" == "on" @echo on

set CsWinRTNet5SdkVersion=5.0.100
set CsWinRTNet5SdkVersion=5.0.300

set this_dir=%~dp0

Expand Down

0 comments on commit 806fe82

Please sign in to comment.