Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeHandle class generation not suppressed when the type is already visibly declared #93

Closed
AArnott opened this issue Feb 16, 2021 · 0 comments · Fixed by #94
Closed

SafeHandle class generation not suppressed when the type is already visibly declared #93

AArnott opened this issue Feb 16, 2021 · 0 comments · Fixed by #94
Assignees
@AArnott
Labels
bug Something isn't working

Comments

@AArnott
Copy link
Member

AArnott commented Feb 16, 2021 •
edited
Loading

In the dotnet/pinvoke project, the NtDll project tries to declare its own CloseHandleSafeHandle type even though it is defined in Kernel32, which it has a reference to.

See also #43
@AArnott AArnott self-assigned this Feb 16, 2021
@AArnott AArnott added the bug Something isn't working label Feb 16, 2021
@AArnott AArnott mentioned this issue Feb 16, 2021
Merged
AArnott added a commit that referenced this issue May 6, 2022
@AArnott
Merge pull request #93 from AArnott/embedPDBs
2ebe738 
Embed PDBs for all local builds

This ensures that if you build a dll and copy it somewhere, then build again, you haven't lost the ability to debug the original dll because it carries the pdb with it wherever it goes.
We do not embed the pdb in the official builds however because the official builds will archive the pdb so it isn't lost, and it would unnecessarily bloat the assembly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress SafeHandle generation when a referencing project already declares it microsoft/CsWin32
1 participant
@AArnott