Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v1.3.1 and v1.2.2. #17

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Nov 16, 2016

These releases correspond to the recently-landed security fixes.

Also breaks up some long lines to make it easier to edit the markdown in a text editor.

Ref chakra-core/ChakraCore#1979
Ref chakra-core/ChakraCore#1982

These releases correspond to the recently-landed security fixes.

Also breaks up some long lines to make it easier to edit the markdown in a text editor.
@dilijev
Copy link
Contributor Author

dilijev commented Nov 16, 2016

/cc @boingoing @liminzhu


This patch release of ChakraCore 1.3 includes the following security fixes:

- [PR #1979](https://github.com/Microsoft/ChakraCore/pull/1979)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this format for release note bullets for consistency? Basically appending PR link at the end and leaving commit link if a PR link is available. It's duplicate information.

  • Change to address CVE-2016-7207 #1979

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. I'll update.

@dilijev dilijev closed this Nov 16, 2016
@dilijev dilijev deleted the release131 branch November 16, 2016 01:29
@dilijev dilijev restored the release131 branch November 16, 2016 01:30
@dilijev dilijev reopened this Nov 16, 2016
@liminzhu
Copy link
Member

👍

@liminzhu
Copy link
Member

Let's merge it!

@dilijev
Copy link
Contributor Author

dilijev commented Nov 21, 2016

Will do, once the releases are actually out. Need to merge the version updates and build before we can publish the packages.

@dilijev dilijev merged commit 17561df into microsoft:master Nov 21, 2016
@dilijev dilijev deleted the release131 branch November 21, 2016 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants