-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GcmHeader types #3572
Merged
Merged
Update GcmHeader types #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
commented
Feb 18, 2022
jumaffre
approved these changes
Feb 18, 2022
gcm_private_impl@42104 aka 20220218.17 vs main ewma over 20 builds from 41777 to 42094 Click to see tablemain
gcm_private_impl
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side effect of #3569 was introducing a new public-header-includes-private chain from
symmetric_key.h
. This was becauseGcmHeader
was templated on theIV_SIZE
, so the implementation details need to be public. I've refactored that soGcmHeader
is no longer templated (but still fixed-size by construction), and derived a supporting type for the users that still want statically known IV sizes.Additionally I've simplified this public interface a little, moving the Tx-encryption specifics (interpreting the IV as a seqno + term + snapshot-bit) out of the public definition, and closer to where it's used.