Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split authentication policies into public definition, private implementation #3536

Merged
merged 6 commits into from
Feb 10, 2022

Conversation

eddyashton
Copy link
Member

A relatively standalone part of #2428.

This moves the existing auth policies from http/authentication to endpoints/authentication, and splits out the private implementation from the public definition. This gives each a clean public interface.

In practice, this exposes that the current publicly available types don't make it easy for apps to implement their own auth policies! But we will deal with that separately, and likely get most of the win from moving service table definitions to public.

@eddyashton eddyashton requested a review from a team February 10, 2022 16:43
@ghost
Copy link

ghost commented Feb 10, 2022

private_auth_impl@41652 aka 20220210.27 vs main ewma over 20 builds from 41340 to 41640

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
41340 20220207.4 5933.18 9.08371e+07 20018.2 1.71746e+07 5662.96 1.58639e+07 2573.97 1.03588e+07 1670.89 1.64237e+08 2247.52 9.57242e+06 1488.63 9.84392e+07 1967.81 9.57242e+06 17636.8 905589 1.36052e+06 9.33025e+06 3.56788e+07
41378 20220207.19 6130.79 9.13613e+07 19815.1 1.76989e+07 5635.16 1.56017e+07 2525.31 1.03588e+07 1616.34 1.63189e+08 2156.48 1.03588e+07 1453.63 9.87014e+07 1955.01 9.04813e+06 20506.3 899819 1.37486e+06 9.11433e+06 3.58669e+07
41385 20220208.2 6097.09 9.13613e+07 19823.7 1.63882e+07 5673.81 1.58639e+07 2582.06 1.03588e+07 1652.63 1.63975e+08 2197.66 9.83456e+06 1483.91 9.81771e+07 2011.93 8.78598e+06 20492.9 909361 1.39034e+06 9.23758e+06 3.56788e+07
41414 20220208.13 5927.14 9.00506e+07 19793.2 1.71746e+07 5569.71 1.56017e+07 2537.67 1.21939e+07 1631.88 1.63975e+08 2195.95 1.03588e+07 1469.44 9.87014e+07 1872.48 9.04813e+06 21149.5 899075 1.38015e+06 9.20855e+06 3.58663e+07
41424 20220208.17 5892.72 9.10992e+07 19642.2 1.74367e+07 5644.26 1.58639e+07 2630.21 1.00967e+07 1612.53 1.64237e+08 2194.64 1.00967e+07 1463.34 9.84392e+07 1970.43 9.31027e+06 17955.7 891748 1.40273e+06 9.38154e+06 3.58042e+07
41442 20220208.24 6063.56 9.08371e+07 19663.5 1.6126e+07 5545.24 1.58639e+07 2537.16 1.03588e+07 1628.47 1.61878e+08 2154.81 9.83456e+06 1484.86 9.87014e+07 1969.91 9.31027e+06 18164.9 871518 1.33515e+06 9.34724e+06 3.45363e+07
41464 20220208.33 5925.87 9.08371e+07 19792.5 1.6126e+07 5663.15 1.56017e+07 2513.25 1.03588e+07 1602.19 1.64237e+08 2147.73 1.00967e+07 1447.26 9.87014e+07 1971.86 9.04813e+06 22552.4 890972 1.38762e+06 9.08192e+06 3.51884e+07
41476 20220208.38 6108.3 8.92642e+07 19761.2 1.6126e+07 5590.68 1.63882e+07 2520.4 1.03588e+07 1640.14 1.63713e+08 2154.25 1.00967e+07 1467.58 9.89635e+07 2006.82 1.11453e+07 18294.9 907593 1.39139e+06 9.22099e+06 3.58036e+07
41485 20220208.41 5875.4 9.03128e+07 19704.3 1.69124e+07 5598.69 1.56017e+07 2541.06 1.03588e+07 1653.24 1.63189e+08 2241.8 9.57242e+06 1468.4 9.84392e+07 1974.01 9.31027e+06 19873 897021 1.37486e+06 9.25436e+06 3.58669e+07
41488 20220209.1 6038.53 8.97885e+07 19812.6 1.69124e+07 5685.19 1.56017e+07 2527.05 1.0621e+07 1669.72 1.645e+08 2219.01 9.83456e+06 1491.83 9.84392e+07 1977.17 9.31027e+06 18255.3 889076 1.37837e+06 9.27952e+06 3.58036e+07
41514 20220209.12 6071.17 9.10992e+07 18864.8 1.63882e+07 5632.81 1.58639e+07 2545.77 1.03588e+07 1652.96 1.61616e+08 2165.42 1.27181e+07 1501.07 9.87014e+07 1969.25 9.31027e+06 20114.8 892446 1.38097e+06 9.33876e+06 3.56174e+07
41527 20220209.17 6034.5 9.00506e+07 19775.5 1.6126e+07 5623.72 1.56017e+07 2529.44 1.03588e+07 1623.27 1.63975e+08 2126.18 1.00967e+07 1474.11 9.84392e+07 1963.83 9.31027e+06 20205.4 905267 1.37532e+06 9.39445e+06 3.65062e+07
41534 20220209.20 6036.01 9.13613e+07 19896.1 1.69124e+07 5580.65 1.56017e+07 2530.8 1.03588e+07 1646.76 1.63451e+08 2168.1 1.00967e+07 1504.47 9.79149e+07 1929.74 9.31027e+06 22235.8 912162 1.36723e+06 9.20441e+06 3.59292e+07
41547 20220209.26 6036.27 9.08371e+07 19700.5 1.6126e+07 5594.69 1.53396e+07 2542.87 1.29803e+07 1625.52 1.63451e+08 2200.49 9.83456e+06 1475.31 9.81771e+07 1969.1 9.04813e+06 22163.7 909449 1.38415e+06 9.20441e+06 3.66362e+07
41567 20220209.35 5906.25 9.05749e+07 19241.8 1.71746e+07 5663.31 1.58639e+07 2531.73 1.0621e+07 1642.12 1.64237e+08 2166.17 9.83456e+06 1468.37 9.87014e+07 1976.81 9.04813e+06 23087.8 916900 1.36469e+06 9.27108e+06 3.56794e+07
41584 20220210.2 6131.01 9.00506e+07 19960.8 1.63882e+07 5654.11 1.56017e+07 2551.73 1.0621e+07 1664.92 1.64762e+08 2206.48 1.00967e+07 1487.85 9.87014e+07 1969.6 9.31027e+06 19737.3 904549 1.36962e+06 9.20028e+06 3.55556e+07
41595 20220210.5 6094.36 9.13613e+07 19008.7 1.6126e+07 5611.82 1.58639e+07 2543.01 1.03588e+07 1660.12 1.64237e+08 2245.55 9.57242e+06 1482.34 9.87014e+07 1973.56 9.31027e+06 20238.4 928160 1.37976e+06 9.48583e+06 3.55556e+07
41607 20220210.9 5970.44 9.08371e+07 19549.1 1.71746e+07 5654.98 1.56017e+07 2528.94 1.08831e+07 1620.85 1.63713e+08 2163.72 9.83456e+06 1454.39 9.87014e+07 1969.85 9.31027e+06 22234.4 914240 1.40562e+06 9.25018e+06 3.58669e+07
41615 20220210.12 6272.34 9.18856e+07 19849.9 1.6126e+07 5602.53 1.56017e+07 2461.72 1.0621e+07 1635.23 1.63451e+08 2207.88 1.00967e+07 1487.32 9.84392e+07 1975 9.31027e+06 20586.9 896039 1.35817e+06 9.37725e+06 3.58042e+07
41640 20220210.23 5899.71 9.00506e+07 19670.6 1.66503e+07 5734.4 1.58639e+07 2540.7 1.03588e+07 1642.61 1.64237e+08 2176.52 1.00967e+07 1480.44 9.89635e+07 1932.21 9.04813e+06 17956.9 905223 1.36906e+06 9.26684e+06 3.58042e+07

private_auth_impl

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
41652 20220210.27 6034.13 9.08371e+07 19725 1.58639e+07 5605.05 1.53396e+07 2543.7 1.27181e+07 1645.06 1.64237e+08 2168.06 9.83456e+06 1458.73 9.84392e+07 1923.31 9.31027e+06 19877.1 905828 1.36952e+06 9.39876e+06 3.57411e+07

images

@achamayou achamayou enabled auto-merge (squash) February 10, 2022 18:45
@achamayou achamayou merged commit 26b8b30 into microsoft:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants