-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split authentication policies into public definition, private implementation #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
commented
Feb 10, 2022
achamayou
reviewed
Feb 10, 2022
achamayou
approved these changes
Feb 10, 2022
private_auth_impl@41652 aka 20220210.27 vs main ewma over 20 builds from 41340 to 41640 Click to see tablemain
private_auth_impl
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively standalone part of #2428.
This moves the existing auth policies from
http/authentication
toendpoints/authentication
, and splits out the private implementation from the public definition. This gives each a clean public interface.In practice, this exposes that the current publicly available types don't make it easy for apps to implement their own auth policies! But we will deal with that separately, and likely get most of the win from moving service table definitions to public.