-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log slow IO operations #3067
Merged
Merged
Log slow IO operations #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
reviewed
Oct 8, 2021
achamayou
reviewed
Oct 8, 2021
ledger_logging@34181 aka 20211008.22 vs main ewma over 20 builds from 33719 to 34113 Click to see table
|
jumaffre
approved these changes
Oct 8, 2021
achamayou
reviewed
Oct 8, 2021
achamayou
approved these changes
Oct 8, 2021
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Oct 8, 2021
eddyashton
added a commit
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass just logs the most expensive call to
read_entry
. Will generalise this to wrap all IO operations, and report if they take over some threshold.