Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record endorsed node certificate in KV store #2844

Merged
merged 79 commits into from
Aug 26, 2021

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Jul 23, 2021

Resolves #2554

[Still very much WIP, in particular with regards to compatibility with 1.x LTS] Now Ready for review!

Node endorsed certificates are now recorded in a new public:ccf.gov.nodes.endorsed_certificates table (rather than self-signed certificates in the existing nodes table).

This has the following implications:

  • New joiners pass their self-signed CSRs to the current primary, which records it in the store on join.
  • Member proposal to trust a node also generates and records the new joiner's endorsed certificate.
  • New joiners should pick up their endorsed certificates from a new KV hook.
  • 2.x nodes should still be able to verify node signatures from a 1.x ledger.

This isn't effective for BFT services (see new entry in configuration table), mostly because the ECDSA signature scheme we use isn't deterministic, and because this will be impacted by the Byzantine identity work.

Tasks:

Julien Maffre and others added 30 commits July 9, 2021 15:10
CHANGELOG.md Outdated Show resolved Hide resolved
src/node/config.h Outdated Show resolved Hide resolved
@achamayou
Copy link
Member

8: ===============================================================================
8: ../src/consensus/aft/test/committable_suffix.cpp:499:
8: TEST CASE:  Multi-term divergence
8: 
8: ../src/consensus/aft/test/committable_suffix.cpp:499: FATAL ERROR: test case CRASHED: SIGSEGV - Segmentation violation signal
8: 
8: ===============================================================================
8: [doctest] test cases:   2 |   1 passed | 1 failed | 12 skipped
8: [doctest] assertions: 102 | 102 passed | 0 failed |
8: [doctest] Status: FAILURE!
8: /__w/1/s/tests/unit_test_wrapper.sh: line 5:  1911 Segmentation fault      (core dumped) LLVM_PROFILE_FILE="${1}.profraw" "./${1}" -nv
 8/65 Test  #8: raft_test .........................***Failed    0.17 sec

In the daily build job.

@jumaffre jumaffre merged commit 92f0475 into microsoft:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose endorsed node certificate
2 participants