-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define more headers as public, and split endpoints into separate library #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename history's Receipt to Proof, pull out real Receipt, restore ccf/ paths
achamayou
reviewed
Mar 18, 2021
This is part of #697. This doesn't yet include the split of |
jumaffre
reviewed
Mar 23, 2021
jumaffre
reviewed
Mar 23, 2021
…o include_cleanup_take3
…o include_cleanup_take3
achamayou
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more-complete replacement for #2312.
This PR makes it so that public headers are included as
ccf/
both locally and against the install, to distinguish them from the private headers (which are still installed, for now).Additionally, it creates a
ccf_endpoints
library to break some of the include chains from app code into our implementation details, with the nice benefit of massively reducing build times for some kinds of change. I think its worth repeating this pattern for other parts of the code but I'm not sure what the next target is - I'd love to do it for the kv but not sure it'll work due to the heavy templating.TODO: