Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define more headers as public, and split endpoints into separate library #2328

Merged
merged 58 commits into from
Mar 25, 2021

Conversation

eddyashton
Copy link
Member

@eddyashton eddyashton commented Mar 17, 2021

This is a more-complete replacement for #2312.

This PR makes it so that public headers are included as ccf/ both locally and against the install, to distinguish them from the private headers (which are still installed, for now).

Additionally, it creates a ccf_endpoints library to break some of the include chains from app code into our implementation details, with the nice benefit of massively reducing build times for some kinds of change. I think its worth repeating this pattern for other parts of the code but I'm not sure what the next target is - I'd love to do it for the kv but not sure it'll work due to the heavy templating.

TODO:

  • Write a CHANGELOG
  • Trim the 3rdparty dependencies that don't need to be public (here)

Rename history's Receipt to Proof, pull out real Receipt, restore ccf/ paths
@eddyashton eddyashton requested a review from a team as a code owner March 17, 2021 11:08
CMakeLists.txt Outdated Show resolved Hide resolved
@eddyashton
Copy link
Member Author

This is part of #697. This doesn't yet include the split of 3rdparty into multiple folders - I have that on a separate branch but would prefer not to pollute this PR (it is almost purely a file rename, so easier to read in isolation).

@achamayou achamayou merged commit b3e7bac into microsoft:main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants