Return an error when the node quote cannot be found #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
error_when_quote_unknown@12528 aka 20200909.42 vs master ewma over 50 builds from 11973 to 12518 |
eddyashton
approved these changes
Sep 9, 2020
achamayou
commented
Sep 9, 2020
tests/governance.py
Outdated
| def test_no_quote(network, args, notifications_queue=None, verify=True): | ||
| primary, _ = network.find_nodes() | ||
| untrusted_node = network.create_and_add_pending_node(args.package, "localhost", args) | ||
| with untrusted_node.client(ca=os.path.join(untrusted_node.common_dir, f"{untrusted_node.node_id}.pem")) as uc: |
There was a problem hiding this comment.
client() otherwise defaults to the network identity as the root CA.
achamayou
force-pushed
the
error_when_quote_unknown
branch
from
098aab9 to
bb4b823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1571