Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc versioning #1124

Merged
merged 30 commits into from
Apr 30, 2020
Merged

Doc versioning #1124

merged 30 commits into from
Apr 30, 2020

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Apr 30, 2020 •
edited
Loading

Fix #770

  • Fix doxygen/breathe

@achamayou achamayou requested a review from a team as a code owner April 30, 2020 11:06
@achamayou achamayou marked this pull request as draft April 30, 2020 11:07
@ccf-bot
Copy link
Collaborator

ccf-bot commented Apr 30, 2020 •
edited
Loading

doc_version@7882 aka 20200430.50 vs master ewma over 50 builds from 7368 to 7860
images

eddyashton
eddyashton reviewed Apr 30, 2020
View reviewed changes
sphinx/requirements.txt Outdated Show resolved Hide resolved
@achamayou achamayou marked this pull request as ready for review April 30, 2020 13:04
eddyashton
eddyashton reviewed Apr 30, 2020
View reviewed changes
sphinx/source/conf.py Outdated Show resolved Hide resolved
jumaffre
jumaffre approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jumaffre jumaffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

FYI, it seems that the GitHub Pages job now takes 7 minutes instead of 45 sec.

@achamayou
Copy link
Member Author

@jumaffre yeah it's building a lot more stuff, so we have to decide how many versions we want to cover I guess. Right now it's anything released, but we could change that to the last X for example.

@achamayou
Copy link
Member Author

I've worked out what's wrong with the includes, this still needs a bit of cleanup but I'll pick it up later, I need a break!

@achamayou
Copy link
Member Author

This looks super promising for many of our warnings: breathe-doc/breathe#512

@achamayou
Copy link
Member Author

This is unfortunately going to need to merge with a red Pages build, because there are literally no branches it can check out with the config in the right path...

@achamayou
Copy link
Member Author

Amusingly, our tests do in fact depend on the documentation (schema_test)!

@achamayou achamayou merged commit 34e846b into microsoft:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton left review comments

@olgavrou olgavrou olgavrou approved these changes

@jumaffre jumaffre jumaffre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioned documentation
5 participants
@achamayou @ccf-bot @eddyashton @olgavrou @jumaffre