Fix client update shell command built from environment values #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildXL/Public/Src/IDE/VsCode/client/src/update.ts
Line 124 in ff35881
Dynamically constructing a shell command with values from the local environment, such as file paths, may inadvertently change the meaning of the shell command. Such changes can occur when an environment value contains characters that the shell interprets in a special way, for instance quotes and spaces. This can result in the shell command misbehaving, or even allowing a malicious user to execute arbitrary commands on the system.
fix the
update.ts
the shell command should be constructed in a way that avoids interpretation by the shell. Instead of interpolating the potentially taintedlatestUpdatePath
directly into the command string, thespawn
function should use its argument array to pass the dynamic values separately. This ensures that special characters in filenames are treated as literal values rather than being interpreted by the shell.spawn
orexecFile
with arguments passed separately instead of interpolating them into the command string.latestUpdatePath
andfile
variables to ensure they do not contain unexpected or malicious input.