Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent theme] Fix files and default exports #5131

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 12, 2024

Changelog Entry

Added

  • (Experimental) Added botframework-webchat-fluent-theme package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120
    • Fixed botframework-webchat-fluent-theme/package.json to export *.d.[m]ts and default exports, in PR #5131

Description

Files that need to be exported in the package.json should be included in the package.json/files.

Also, default exports should point to valid file.

Design

Specific Changes

  • Updated packages/fluent-theme/package.json
    • Added *.d.[m]ts to files so it is packed correctly
    • Fixed main/types field so it is pointing to correct files
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title Fix files and default exports [Fluent theme] Fix files and default exports Apr 12, 2024
@compulim compulim marked this pull request as ready for review April 12, 2024 18:53
tdurnford
tdurnford previously approved these changes Apr 12, 2024
@compulim compulim merged commit 1b71f01 into main Apr 15, 2024
25 checks passed
@compulim compulim deleted the fix/fluent-package-json branch April 15, 2024 18:47
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants