Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LinkText and underline to HC button-link #4537

Merged
merged 7 commits into from
Dec 9, 2022

Conversation

beyackle2
Copy link
Contributor

@beyackle2 beyackle2 commented Dec 1, 2022

Fixes ADO issue 15603122 (https://msazure.visualstudio.com/CCI/_workitems/edit/15603122)

Changelog Entry

Fixed

Description

High-contrast themes like Desert and Aquatic render button text in the same color as ordinary text. This is a problem when we use a button to mimic a link (as we do in InlineMarkdown), because then the text blends into the surrounding text.

Specific Changes

This adds a @media forced-colors selector to InlineMarkdown that adds the semantic LinkText color and a single underline to links that have been turned from Markdown into buttons; this makes them visually distinct.

[in draft until there are unit tests]

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@beyackle2 beyackle2 marked this pull request as ready for review December 9, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants