Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Adaptive Cards 2.11.1 #4424

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 27, 2022

Also fixed #4417.

Changelog Entry

Changed

Description

Bump Adaptive Cards to 2.11.1.

Specific Changes

  • Bumped to adaptivecards@2.11.1
  • Fixed some tests positively impacted by accessibility fixes done in Adaptive Cards library
    • accessibility.adaptiveCard.disabled.inputs.html: Button group container now become tabbable through tabindex="0"
    • accessibility.adaptiveCard.disabled.focus.withShowCard.html: "Show card" button no longer causes other buttons in the same card to be unable to focus
  • Improved reliability of some tests related to live region narrations
    • We use useEffect to render something which we would expect in tests
    • Rather than calling expect immediately, we should use waitFor those expectations
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the release Release checklist label Sep 28, 2022
@compulim compulim marked this pull request as ready for review September 28, 2022 17:44
@compulim compulim merged commit 68ad442 into microsoft:main Oct 4, 2022
@compulim compulim deleted the bump-ac-2.11.1 branch October 4, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test reliability chores
2 participants