Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample to echo typing as message #4063

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 27, 2021

Related to #4031.

Changelog Entry

Samples

Description

To reduce confusion, the sample is updated to echo back typing activity as a message, instead of a typing activity.

Design

Today, in this sample, when the end-user type, the bot will send a corresponding typing activity. As a result, a typing indicator GIF animation will be shown.

image

This behavior confuses accessibility audit team as the GIF animation is not desirable when the end-user type.

This PR will update the sample. The bot will send a message activity instead.

image

Specific Changes

  • Updated sample 05.b to send echo-typing-as-message command, instead of echo-typing command
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title Fix 4031 Respond typing with message Update sample to echo typing as message Sep 27, 2021
@cwhitten cwhitten merged commit a9e6b84 into microsoft:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants