Update sample to echo typing as message #4063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Samples
05.custom-components/b.send-typing-indicator
to reply withmessage
activity, instead oftyping
activity, in PR #4063, by @compulimDescription
To reduce confusion, the sample is updated to echo back
typing
activity as a message, instead of atyping
activity.Design
Today, in this sample, when the end-user type, the bot will send a corresponding
typing
activity. As a result, a typing indicator GIF animation will be shown.This behavior confuses accessibility audit team as the GIF animation is not desirable when the end-user type.
This PR will update the sample. The bot will send a message activity instead.
Specific Changes
05.b
to sendecho-typing-as-message
command, instead ofecho-typing
commandI have added tests and executed them locallyCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)