Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples cleanup #3870

Merged
merged 14 commits into from
May 1, 2021
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ instructions provided by the bot. You will only need to do this once across all

Thanks for your interest in improving Web Chat. We invest heavily in engineering excellence to reduce our workloads and enable us to move faster. To start the development, please familiarize yourself with the development process and these automation tools.

> If you need to build this project for customization purposes, we strongly advise you to refer to our [samples](https://github.com/microsoft/BotFramework-WebChat/tree/master/samples). If you cannot find any samples that fulfill your customization needs and you don't know how to do that, please [send your dream to us](https://github.com/microsoft/BotFramework-WebChat/issues/).
> If you need to build this project for customization purposes, we strongly advise you to refer to our [samples](https://github.com/microsoft/BotFramework-WebChat/tree/main/samples). If you cannot find any samples that fulfill your customization needs and you don't know how to do that, please [send your dream to us](https://github.com/microsoft/BotFramework-WebChat/issues/).
>
> Forking Web Chat to make your own customizations means you will lose access to our latest updates. Maintaining forks also introduces chores that are substantially more complicated than a version bump.

Expand Down Expand Up @@ -46,7 +46,7 @@ npm run bootstrap

# Building the project

> Default build flavor is development. Please read [BUILD_SCRIPTS.md](https://github.com/microsoft/BotFramework-WebChat/blob/master/docs/BUILD_SCRIPTS.md) about different build flavors.
> Default build flavor is development. Please read [BUILD_SCRIPTS.md](https://github.com/microsoft/BotFramework-WebChat/blob/main/docs/BUILD_SCRIPTS.md) about different build flavors.

There are two ways to build: one-off and continuous build.

Expand Down Expand Up @@ -181,14 +181,14 @@ There are checks that automation will not be able to capture. For example:
- Safari on macOS
- Safari on iOS or iPadOS
- Chrome on Android
- For accessibility, please refer to [`docs/ACCESSIBILITY.md`](https://github.com/microsoft/BotFramework-WebChat/blob/master/docs/ACCESSIBILITY.md)
- For accessibility, please refer to [`docs/ACCESSIBILITY.md`](https://github.com/microsoft/BotFramework-WebChat/blob/main/docs/ACCESSIBILITY.md)
- Tab order, content readability, assistive technology-only text, color contrast, etc. must be maintained.
- Assistive technology and browser compatibility
- NVDA/JAWS: Chrome and Firefox
- Narrator: Microsoft Edge family and IE11
- VoiceOver: Safari
- TalkBack: Chrome on Android
- For internationalization, please refer to [`docs/LOCALIZATION.md`](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/LOCALIZATION.md)
- For internationalization, please refer to [`docs/LOCALIZATION.md`](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/LOCALIZATION.md)
- Feature documentation, samples, live demo, operation of demo bots
- All samples must also come with a hosted live demo
- Please discuss with us if a specific bot is needed for the live demo
Expand Down Expand Up @@ -229,13 +229,13 @@ Write the user story while implementing the feature.
- Verify screenshots
1. Write a new sample with `README.md`
- This is the user story and proof-of-record on how the feature will work
- Update [`samples/README.md`](https://github.com/microsoft/BotFramework-WebChat/blob/master/samples/README.md)
1. Add more design docs to [`/docs`](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs) as needed
- Update [`samples/README.md`](https://github.com/microsoft/BotFramework-WebChat/blob/main/samples/README.md)
1. Add more design docs to [`/docs`](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs) as needed
1. Add a few log entries to `CHANGELOG.md`
1. File a pull request

## Additional context

### Adding languages

To add a new language to our localization list, please refer to [`docs/LOCALIZATION.md`](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/LOCALIZATION.md).
To add a new language to our localization list, please refer to [`docs/LOCALIZATION.md`](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/LOCALIZATION.md).
2 changes: 1 addition & 1 deletion .github/HowToQuestions.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Please feel free to peruse our [samples](https://github.com/microsoft/BotFramework-WebChat/tree/master/samples), which provide a lot of ideas and foundation for customizing your version of Web Chat.
Please feel free to peruse our [samples](https://github.com/microsoft/BotFramework-WebChat/tree/main/samples), which provide a lot of ideas and foundation for customizing your version of Web Chat.

'How to' questions such as this one are better suited for [Stack Overflow](https://stackoverflow.com/tags/botframework). Please feel free to post other questions you have about developing your own features over there so the community at large may help out. If you need help with a Web Chat implementation, you can post a question to the [Web Chat tag](https://stackoverflow.com/questions/tagged/web-chat). Thank you!

Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ labels: Bug, Pending, customer-reported, Bot Services
assignees: ''
---

# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.
# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.

<!-- ATTENTION: Bot Framework internals, please remove the `customer-reported` and `Bot Services` labels before submitting this issue. -->

<!-- [GitHub issues](https://github.com/microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/TECHNICAL_SUPPORT_GUIDE.md) to get support related to Bot Framework and Web Chat. -->
<!-- [GitHub issues](https://github.com/microsoft/botframework-webchat/issues) should be used for bugs and feature requests. See the [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/TECHNICAL_SUPPORT_GUIDE.md) to get support related to Bot Framework and Web Chat. -->

## Screenshots

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ labels: feature-request, customer-reported, Bot Services
assignees: ''
---

# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.
# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.

<!-- ATTENTION: Bot Framework internals, please remove the `customer-reported` and `Bot Services` labels before submitting this issue. -->

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ assignees: ''

# 🚨 The issue tracker is not for implementation questions 🚨

# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/master/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.
# Please view our [Technical Support Guide](https://github.com/microsoft/BotFramework-WebChat/tree/main/docs/TECHNICAL_SUPPORT_GUIDE.md) before filing a new issue.

<!-- ATTENTION: Bot Framework internals, please remove the `customer-reported` and `Bot Services` labels before submitting this issue. -->

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playground.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: playground
on:
push:
branches:
- master
- main
paths:
- .github/workflows/playground.yaml
- packages/**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-github-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches:
- main
- master
- main
corinagum marked this conversation as resolved.
Show resolved Hide resolved
paths:
- .github/workflows/publish-github-pages.yaml
- samples/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: samples/07.a.upload-to-azure-storage
on:
push:
branches:
- master
- main
paths:
- .github/workflows/samples.07.a.upload-to-azure-storage.yaml
- samples/07.advanced-web-chat-apps/a.upload-to-azure-storage/**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/samples.07.b.sso-for-enterprise.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: samples/07.b.sso-for-enterprise
on:
push:
branches:
- master
- main
paths:
- .github/workflows/samples.07.b.sso-for-enterprise.yaml
- samples/07.advanced-web-chat-apps/b.sso-for-enterprise/**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/samples.07.c.sso-for-intranet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: samples/07.c.sso-for-intranet
on:
push:
branches:
- master
- main
paths:
- .github/workflows/samples.07.c.sso-for-intranet.yaml
- samples/07.advanced-web-chat-apps/c.sso-for-intranet/**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/samples.07.d.sso-for-teams.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: samples/07.d.sso-for-teams
on:
push:
branches:
- master
- main
paths:
- .github/workflows/samples.07.d.sso-for-teams.yaml
- samples/07.advanced-web-chat-apps/d.sso-for-teams/**
Expand Down
22 changes: 0 additions & 22 deletions .travis.yml

This file was deleted.

Loading