Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions for StyleOptions #3818

Merged
merged 21 commits into from
Mar 30, 2021
Merged

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Mar 29, 2021

Fixes #2100

Changelog Entry

  • Resolves #2100. Add types declarations for Style Options in api bundle, by @corinagum, in PR #3818

Description

By popular request! This set of changes provides type declarations for Web Chat's style options.

Design

Types file is exported to /types under api package.

Specific Changes

  • Clean up of StyleOption props
    • Several props were spread across two defaultStyleOptions.js :o
    • Update several props from null / empty string default value to undefined
    • Alphabetize props by category
  • Delete defaultStyleOptions.js in /component/Styles/ package
  • Add typescript linting to eslint
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

@corinagum corinagum merged commit a13bfd8 into microsoft:master Mar 30, 2021
@corinagum corinagum mentioned this pull request Mar 31, 2021
@compulim compulim mentioned this pull request Jun 9, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a way to obtain webchat.d.ts file
2 participants