-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3453 Fixes plain text file attachments to show download link when uploaded #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
February 8, 2021 18:40
amal-khalaf
reviewed
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left one question
packages/component/src/Middleware/AttachmentForScreenReader/createCoreMiddleware.js
Outdated
Show resolved
Hide resolved
compulim
reviewed
Feb 9, 2021
packages/component/src/Middleware/Attachment/createCoreMiddleware.js
Outdated
Show resolved
Hide resolved
packages/component/src/Middleware/AttachmentForScreenReader/TextAttachment.js
Outdated
Show resolved
Hide resolved
packages/component/src/Middleware/Attachment/createCoreMiddleware.js
Outdated
Show resolved
Hide resolved
compulim
reviewed
Feb 9, 2021
packages/component/src/Middleware/AttachmentForScreenReader/TextAttachment.js
Outdated
Show resolved
Hide resolved
compulim
reviewed
Feb 9, 2021
packages/component/src/Middleware/AttachmentForScreenReader/createCoreMiddleware.js
Outdated
Show resolved
Hide resolved
compulim
reviewed
Feb 9, 2021
…eateCoreMiddleware.js Co-authored-by: William Wong <compulim@users.noreply.github.com>
compulim
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Previously, attachments of type plain text were uploaded and shown as an empty bubble. This fix now shows the attachment as a download link with size listed as well.
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed