Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchors being disabled in obsolete Adaptive Cards #3687

Merged
merged 6 commits into from
Jan 28, 2021

Conversation

corinagum
Copy link
Contributor

Fixes #3618
Fixes #3582

Changelog Entry

Description

Previously, Adaptive Cards that have been marked as obsolete in the DOM were disabling anchors, which is invalid behavior. This change makes it so that while other inputs are disabled, anchors remain enabled and can be clicked/navigated to when in an older message in the transcript.

This also fixes the Disable Adaptive Cards sample, which had an error in it.

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link

@amal-khalaf amal-khalaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending comments

packages/playground/src/App.js Outdated Show resolved Hide resolved
packages/playground/src/App.js Show resolved Hide resolved
packages/playground/src/App.js Show resolved Hide resolved
@corinagum corinagum merged commit 723a4c3 into microsoft:master Jan 28, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants