Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested actions flow layout #3641

Merged
merged 6 commits into from
Dec 24, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 15, 2020

Fixes #2745.

Changelog Entry

Added

Description

Added a new layout to suggested action: inline. And a new option to curb the height of the container and make it scrollable: suggestedActionsInlineMaxHeight.

image

Specific Changes

  • Added new layout to SuggestedActions.js, and refactored
  • Modified SuggestedAction.js to use non-flexbox for laying out images inside buttons
  • Updated styleOptions:
    • Added new flow option to suggestedActionLayout
    • Added new suggestedActionsInlineMaxHeight
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum changed the title Add suggested actions inline layout Add suggested actions float layout Dec 18, 2020
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, + don't forget to rename to flow instead of inline. LGTM!

@compulim compulim force-pushed the feat-suggested-actions-inline branch from a87c999 to 7c14c83 Compare December 22, 2020 19:44
@compulim compulim changed the title Add suggested actions float layout Add suggested actions flow layout Dec 22, 2020
@compulim compulim merged commit 5109552 into microsoft:master Dec 24, 2020
@compulim compulim deleted the feat-suggested-actions-inline branch December 24, 2020 00:55
@eedwards36
Copy link

When will this be released? Also what is the exact usage?

e.g. suggestedActionLayout: 'inline',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show suggested actions horizontally with line-break
3 participants