Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert typing activity into transcript #3554

Merged
merged 7 commits into from
Oct 24, 2020
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 21, 2020

Fixes #3431.

Changelog Entry

Fixed

  • Fixes #3431. Activities should not be delayed due to missing activity of type "typing", by @compulim in PR #3554

Description

Today, typing activity was not inserted into transcript. This is causing incoming activity to be delayed if they are replying to that typing activity.

Tomorrow, we are inserting the typing activity into the transcript but not displaying them. Since they are in the transcript, incoming activities will be able to infer them and not to be delayed.

Design

Specific Changes

  • Updated reducer/activities.js not to filter out activity of type typing
  • Added warning if an activity is being delayed because the activity it is replying to was not in the transcript
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending one comment.

@compulim compulim merged commit fe64eac into master Oct 24, 2020
@compulim compulim deleted the fix-3431-typing-delay branch October 24, 2020 04:59
@compulim compulim mentioned this pull request Oct 29, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First welcome message is delayed for 5 seconds
2 participants