Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix herocard image alt & receiptcard quantity/tap/text props #3541

Merged
merged 8 commits into from
Oct 19, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 15, 2020

Fixes #3310, Fixes #3371, Fixes #3541

Changelog Entry

Description

  • Add quantity, tap, & text props to ReceiptCard
  • Add alt property to card images (Thumbnail)
  • Add info about composition mode in sample 06.d

Notes:

  • alt and tap props are not currently tested
  • quantity is tested in receiptcard2
  • if no quantity, '× quantity' is not shown (see receiptcard)
  • receiptcard snapshot changed because MockBot previously had the text property, and snapshot now shows that text.
  • new snapshots for several pre-existing tests - they mostly have to do with the help command, which changes the scrollbar due to a new command that's now listed

Design

Specific Changes

image
image

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum merged commit 67da325 into microsoft:master Oct 19, 2020
@compulim compulim mentioned this pull request Oct 29, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants