Send box renderer #3532

felixvanleeuwen · 2020-10-12T09:22:54Z

Fixes #3526
Fixes #3038

Description

Added a prop that is sent down into BasicWebChat and is used to render the send box if not undefined.

Specific Changes

Added a prop to BasicWebChat defaultProps.
Added a check in the BasicWebChat render to use the new prop instead of rendering the BasicSendBox

Review Checklist

This section is for contributors to review your work.

Accessibility reviewed (tab order, content readability, alt text, color contrast)
Browser and platform compatibilities reviewed
CSS styles reviewed (minimal rules, no z-index)
Documents reviewed (docs, samples, live demo)
Internationalization reviewed (strings, unit formatting)
package.json and package-lock.json reviewed
Security reviewed (no data URIs, check for nonce leak)
Tests reviewed (coverage, legitimacy)

ghost · 2020-10-12T09:23:09Z

All CLA requirements met.

corinagum · 2020-10-12T21:22:36Z

Thanks for the PR!!

Please fill out the CLA
Could you add the passing snapshots to the committed files? They need to be present in order for the CI to pass.

I'll take a closer look at this sometime this week.

corinagum

This will need to be updated to use the middleware format rather than the deprecated renderer format. Please address that and above requests as well. :)

@compulim feel free to add. Do you think this is a good middle step while we wait for the new sendbox design?

corinagum · 2020-10-12T21:48:25Z

packages/component/src/BasicWebChat.js

@@ -82,9 +85,11 @@ const BasicWebChat = ({ className }) => {
 export default BasicWebChat;

 BasicWebChat.defaultProps = {
-  className: ''
+  className: '',
+  sendBoxRenderer: undefined


Rather than renderer, this will need to be changed to sendBoxMiddleware.

https://github.com/microsoft/BotFramework-WebChat/tree/master/packages/component/src/Middleware

I added a new issue to get rid of our deprecations to reduce confusion: #3534

@compulim, do you have thoughts?

I've changed the name of the prop.

"Middleware" implies that can it can be inserted in between existing logic.
This prop is very much an alternative route that can be used, once used it can't pass on to existing logic.

Having said that, do you still feel this is the correct name for the prop?
Or did you mean my solution should be a middleware and I have to change my implementation?

The implementation should be middleware. :) I think there are other considerations that @compulim would like to comment on as well. Pinging him.

@compulim is the change satisfactory?

fix tests with new snapshots

felixvanleeuwen · 2020-10-16T11:28:36Z

I've updated the snaps but the CI still fails.
When I try to check the "Details" I get a 401.

How do I check why my CI is failing?

corinagum · 2020-10-16T17:50:15Z

@felixvanleeuwen thanks for the updates! Unfortunately non-internal developers are unable to check the CI. Some of them are DL timeouts, so I'm rerunning right now and after that I'll make a list of the failing tests. Thanks for your patience.

corinagum · 2020-10-16T17:51:05Z

@compulim ping

felixvanleeuwen · 2020-10-20T11:39:29Z

Any news on the failing CI?

…BotFramework-WebChat into SendBoxRenderer

felixvanleeuwen · 2020-11-11T15:51:25Z

@compulim Is this how you imagined it?

corinagum · 2020-11-11T21:07:24Z

@felixvanleeuwen Thanks for the updates! FYI, compulim is currently on vacation and will be unavailable for a few weeks. Since he wanted to go through the code, I'll go through and possibly leave a few comments, but we'll wait until he's back for the approval.

We just finished a release milestone, and our next is scheduled for next year, so presumably we'll still be able to get this into the next release.

Thanks for your patience!

corinagum · 2020-11-11T21:08:03Z

samples/02.branding-styling-and-customization/l.idiosyncratic-send-box-rendering/README.md

+
+# Test out the hosted sample
+
+-  [Try out MockBot](https://microsoft.github.io/BotFramework-WebChat/02.branding-styling-and-customization/j.enable-emoji)


corinagum · 2020-11-11T21:15:01Z

You don't need to do this immediately, since there will be frequent changes to CHANGELOG.md that will cause merge conflicts, but before this gets merged in, you will need to give yourself credit and add the changes to the Changelog :) I would include a line under Added in Unreleased for the SendBox changes, and an entry under Samples for the new sample.

Please also add this sample to the /samples/README.md table. Thanks again :)

…BotFramework-WebChat into SendBoxRenderer

felixvanleeuwen · 2020-12-24T10:21:13Z

Hello, is there anything blocking about this PR still?
I'd like to hear what's wrong so I can take steps to remedy.

felixvanleeuwen · 2021-01-12T16:00:16Z

Hello?

corinagum · 2021-02-09T23:39:36Z

Hi @felixvanleeuwen sorry I missed your reply. We still need @compulim to do a pass review, but there are still issues unaddresed above that should be fixed. Please take a look at those.

felixvanleeuwen · 2021-02-10T09:17:12Z

I think all of the issues have been addressed.
If you feel that some have not been addressed: could you specifically list them?

corinagum · 2021-03-24T19:00:05Z

Reopening - I'm assuming close was unintentional :) Please let me know if not.

sibbl · 2022-04-21T11:35:18Z

Sorry for bringing up this PR again, but is there still any interest in being able to implement a custom search box? From a developers perspective it makes perfect sense to have a middleware for this just like we have for all other crucial parts of the UI.

Or is there some sample of solving it with current tools, as I saw that there's a hideSendBox style option?

compulim · 2024-04-08T20:40:47Z

Obsoleted by #5120.

felixvanleeuwen added 6 commits October 9, 2020 12:44

sendBoxRenderer prop

317dbf9

receive props as argument

685c4a7

parenthesis

a00dd46

rename var

4cd2f97

added tests

1646e91

added sample page

10c4ebe

felixvanleeuwen requested review from a-b-r-o-w-n, beyackle, compulim, corinagum, cwhitten, srinaath, tdurnford and tonyanziano as code owners October 12, 2020 09:22

corinagum self-assigned this Oct 12, 2020

corinagum suggested changes Oct 12, 2020

View reviewed changes

corinagum removed their assignment Oct 12, 2020

felixvanleeuwen and others added 3 commits October 13, 2020 09:29

rename

b046cc2

fix tests with new snapshots

8637ee9

Merge pull request #1 from PrPleGoo/SendBoxRenderer

b96c665

fix tests with new snapshots

corinagum assigned compulim Oct 16, 2020

Merge branch 'master' into SendBoxRenderer

d2357a7

felixvanleeuwen added 3 commits November 11, 2020 16:10

middleware refactor start

11725f5

Merge branch 'SendBoxRenderer' of https://github.com/felixvanleeuwen/…

6c710ba

…BotFramework-WebChat into SendBoxRenderer

fix test

70a8198

update readme

3b82468

Merge branch 'master' into SendBoxRenderer

8286225

corinagum reviewed Nov 11, 2020

View reviewed changes

felixvanleeuwen added 2 commits November 12, 2020 09:33

Update sample, set test differently

30e2fe9

Merge branch 'SendBoxRenderer' of https://github.com/felixvanleeuwen/…

13c0ca0

…BotFramework-WebChat into SendBoxRenderer

corinagum added the needs-peer-review label Jan 13, 2021

Merge branch 'master' into SendBoxRenderer

2470fa1

corinagum requested a review from amal-khalaf as a code owner February 9, 2021 23:38

add credits in changelog

ee1922b

Merge branch 'master' into SendBoxRenderer

0e0cdf5

felixvanleeuwen closed this Mar 24, 2021

corinagum reopened this Mar 24, 2021

compulim closed this Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send box renderer #3532

Send box renderer #3532

felixvanleeuwen commented Oct 12, 2020

ghost commented Oct 12, 2020 •

edited by ghost

Loading

corinagum commented Oct 12, 2020

corinagum left a comment

corinagum Oct 12, 2020

felixvanleeuwen Oct 13, 2020

corinagum Oct 13, 2020

felixvanleeuwen Dec 18, 2020

felixvanleeuwen commented Oct 16, 2020

corinagum commented Oct 16, 2020

corinagum commented Oct 16, 2020

felixvanleeuwen commented Oct 20, 2020

felixvanleeuwen commented Nov 11, 2020

corinagum commented Nov 11, 2020

corinagum Nov 11, 2020

corinagum commented Nov 11, 2020

felixvanleeuwen commented Dec 24, 2020

felixvanleeuwen commented Jan 12, 2021

corinagum commented Feb 9, 2021

felixvanleeuwen commented Feb 10, 2021

corinagum commented Mar 24, 2021

sibbl commented Apr 21, 2022

compulim commented Apr 8, 2024


		# Test out the hosted sample

		- [Try out MockBot](https://microsoft.github.io/BotFramework-WebChat/02.branding-styling-and-customization/j.enable-emoji)

Send box renderer #3532

Send box renderer #3532

Conversation

felixvanleeuwen commented Oct 12, 2020

Description

Specific Changes

Review Checklist

ghost commented Oct 12, 2020 • edited by ghost Loading

corinagum commented Oct 12, 2020

corinagum left a comment

Choose a reason for hiding this comment

corinagum Oct 12, 2020

Choose a reason for hiding this comment

felixvanleeuwen Oct 13, 2020

Choose a reason for hiding this comment

corinagum Oct 13, 2020

Choose a reason for hiding this comment

felixvanleeuwen Dec 18, 2020

Choose a reason for hiding this comment

felixvanleeuwen commented Oct 16, 2020

corinagum commented Oct 16, 2020

corinagum commented Oct 16, 2020

felixvanleeuwen commented Oct 20, 2020

felixvanleeuwen commented Nov 11, 2020

corinagum commented Nov 11, 2020

corinagum Nov 11, 2020

Choose a reason for hiding this comment

corinagum commented Nov 11, 2020

felixvanleeuwen commented Dec 24, 2020

felixvanleeuwen commented Jan 12, 2021

corinagum commented Feb 9, 2021

felixvanleeuwen commented Feb 10, 2021

corinagum commented Mar 24, 2021

sibbl commented Apr 21, 2022

compulim commented Apr 8, 2024

ghost commented Oct 12, 2020 •

edited by ghost

Loading