Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump encoding@0.1.13 in samples/06.recomposing-ui/c.smart-display #3458

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 9, 2020

Fixes CD pipeline.

Changelog Entry

Samples

Description

encoding@0.1.12 is causing issues in our CD pipeline because the way it resolve iconv-lite and Webpack is giving warning that would trigger an error in CD pipeline. See andris9/encoding#18.

Excerpt of the problematic code:

'use strict';

var iconv_package;
var Iconv;

try {
    // this is to fool browserify so it doesn't try (in vain) to install iconv.
    iconv_package = 'iconv';
    Iconv = require(iconv_package).Iconv;
} catch (E) {
    // node-iconv not present
}

And it caused an error:

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

./node_modules/encoding/lib/iconv-loader.js
Critical dependency: the request of a dependency is an expression

Design

Bumped from encoding@^0.1.11 (actual 0.1.12) to encoding@0.1.13.

Specific Changes

  • Updated samples/06.recomposing-ui/c.smart-display/package-lock.json to use encoding@0.1.13
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit b4eca64 into master Sep 9, 2020
@compulim compulim deleted the fix-sample-iconv branch September 9, 2020 02:41
@compulim compulim mentioned this pull request Sep 9, 2020
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants