Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honoring className prop #3300

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Honoring className prop #3300

merged 3 commits into from
Jul 13, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 10, 2020 •
edited
Loading

Fixes #3297.

Changelog Entry

Fixed

Description

After the recent enable composition mode PR, the className prop was not honored.

Specific Changes

  • Update <ReactWebChat> to pass className prop to <BasicWebChat>
  • Testing Added

corinagum
corinagum approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test need a screencapture? other than that, LGTM

@compulim
Copy link
Contributor Author

Oh right, missed that. Will add soon.

@compulim compulim merged commit 415cee8 into microsoft:master Jul 13, 2020
@compulim compulim deleted the fix-3297-root-classname branch July 13, 2020 12:09
@compulim compulim mentioned this pull request Jul 13, 2020
Closed
42 tasks
@corinagum corinagum mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"className" prop is not working on <ReactWebChat>
2 participants
@compulim @corinagum