Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to adaptivecards@1.2.6 and disable tabindex #3193

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jun 3, 2020

Fixes #1340.

Changelog Entry

Fixed

  • Fixes #1340. Card container should not be focusable if they do not have tapAction, by @compulim in PR #3193

Changed

Description

Card container should not be focusable (no tabIndex="0") if they do not have tapAction. This requires bumping to Adaptive Cards 1.2.6 plus a global settings.

Specific Changes

  • Bump to adaptivecards@1.2.6
  • Set AdaptiveCards.GlobalSettings.setTabIndexAtCardRoot to true if the card has tapAction prop, otherwise false
  • Update tests and screenshots that related to "root container is TAB-able"

  • Testing Added

@compulim compulim marked this pull request as ready for review June 3, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants