Docs updates and sample fixes #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
commented
Mar 2, 2020
| @@ -157,20 +180,23 @@ Please note, however: | |||
| - Web Chat has no plan to support samples for IE11 (ES5). | |||
| - For customers who wish to manually rewrite our other samples to work in IE11, we recommend looking into converting code from ES6+ to ES5 using polyfills and transpilers like [`babel`](https://babeljs.io/docs/en/next/babel-standalone.html). | |||
|
|
|||
| # How to connect a client app to bot | |||
corinagum
commented
Mar 2, 2020
| | `store` | Specify a custom store, e.g. for adding programmatic activity to the bot. | | ||
| | `styleOptions` | Object that stores customization values for your styling of Web Chat. For the complete list of (frequently updated) default style options, please see the [defaultStyleOptions.js](https://github.com/microsoft/BotFramework-WebChat/blob/master/packages/component/src/Styles/defaultStyleOptions.js) file. | | ||
| | `styleSet` | The non-recommended way of overriding styles. | | ||
| | `userID` | Specify a userID. There are two ways to specify the `userID`: in props, or in the token when generating the token call (`createDirectLine()`). If both methods are used to specify the userID, the token userID property will be used, and a `console.warn` will appear during runtime. If the `userID` is provided via props but is prefixed with `'dl'`, e.g. `'dl_1234'`, the value will be thrown and a new `ID` generated. If `userID` is not specified, it will default to a random user ID. Multiple users sharing the same user ID is not recommended; their user state will be shared, which creates a security risk when authenticating. | |
There was a problem hiding this comment.
Line 25 is where docs changed; everything else is spacing
tdurnford
approved these changes
Mar 2, 2020
|
rerunning CI for test timeouts |
|
Ok I have tests passing in vsts, but it's not updating on GH. I'm squash and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2941
Fixes #2921
Fixes #2948
Changelog Entry
Description
LOCALIZATION.md,NOTIFICATION.md, andTELEMETRY.mdin docsuserID, since this is a common pain point- [ ] Testing Added