Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show download link and icon based on contentUrl #2868

Merged
merged 10 commits into from
Feb 6, 2020
Merged

Show download link and icon based on contentUrl #2868

merged 10 commits into from
Feb 6, 2020

Commits on Feb 6, 2020

  1. Replace DownloadAttachment and UploadAttachment with FileAttachment

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    c930804 View commit details
    Browse the repository at this point in the history

  2. Add entry

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    f4f52a2 View commit details
    Browse the repository at this point in the history

  3. Add PR number

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    0636aa9 View commit details
    Browse the repository at this point in the history

  4. Add optionals

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    5f85b5e View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    fd33b0c View commit details
    Browse the repository at this point in the history

  6. Test for FileAttachment

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    d040f59 View commit details
    Browse the repository at this point in the history

  7. Also check for <a>

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    b508c27 View commit details
    Browse the repository at this point in the history

  8. Test relliability

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    3b23044 View commit details
    Browse the repository at this point in the history

  9. Update CHANGELOG.md 

    Co-Authored-By: TJ Durnford <tjdford@gmail.com>
    @compulim @tdurnford
    compulim and tdurnford committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    00364f7 View commit details
    Browse the repository at this point in the history

  10. Apply PR comments

    @compulim
    compulim committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    68d53ba View commit details
    Browse the repository at this point in the history