Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Timestamp into SendStatus component #2786

Merged
merged 6 commits into from
Jan 4, 2020
Merged

Moved Timestamp into SendStatus component #2786

merged 6 commits into from
Jan 4, 2020

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Dec 31, 2019 •
edited
Loading

Fixes #2747

Changelog Entry

Fixes #2747. Moved Timestamp into the SendStatus component and removed the Timestamp style set, by @tdurnford in PR #2786

Description

Moved the TimeStamp component from the StackedLayout and CarousalLayout components to the SendStatus component reducing redundant code across the layouts.

Additional Context

Simplifies code changes for #2722

  • Testing Added

@coveralls
Copy link

coveralls commented Dec 31, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 65.89% when pulling 0edce39 on tdurnford:2747 into 7946bde on microsoft:master.

corinagum
corinagum approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, I like how much it cleans up the code. :)

@corinagum corinagum merged commit ba47fed into microsoft:master Jan 4, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Timestamp into SendStatus Component
3 participants
@tdurnford @coveralls @corinagum