Sample 12 prevent reconnection and move to functional component #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
changed the title
This text in your PR description will close issue 2750, so you should remove the resolve in front of it. |
tdurnford
reviewed
Dec 18, 2019
samples/12.customization-minimizable-web-chat/src/MinimizableWebChat.js
Outdated
Show resolved
Hide resolved
|
Is there a reason this hasn't been merged in? We have a ton of potentially stale PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
In sample 12 "minimizable Web Chat", when Web Chat is minimized, it disconnect Direct Line. When Web Chat is restored, it reconnect.
Temporarily, we hide Web Chat by setting
display: none. This is not an ideal fix.We need #2750 to be resolved before we could implement an ideal fix.
Specific Changes
display: noneinstead of unmounting Web Chat from DOM treeTesting Added