Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Object.is polyfill #2719

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Add Object.is polyfill #2719

merged 1 commit into from
Dec 12, 2019

Conversation

compulim
Copy link
Contributor

Fixes #2718.

Changelog Entry

Fixed

Description

Usage of Object.is was added in #2710 but the polyfill for ES5 browsers was not added.

Specific Changes

  • Add corejs/features/object/is to ES5 bundle
  • Testing Added
    • Manual test steps
    1. Load ES5 bundle in IE11, the UI should show up

@compulim compulim mentioned this pull request Dec 12, 2019
Closed
73 tasks
@compulim compulim changed the title Add Object.is Add Object.is polyfill Dec 12, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.108% when pulling 89f814e on compulim:fix-2718 into 9e43da0 on microsoft:master.

tdurnford
tdurnford approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 7d67f26 into microsoft:master Dec 12, 2019
@compulim compulim deleted the fix-2718 branch December 12, 2019 17:42
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Pre-release: Need Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES5 bundle should load Object.is polyfill
3 participants
@compulim @coveralls @tdurnford