Added check to ensure Adaptive Card's content is an Object #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
corinagum
approved these changes
Nov 12, 2019
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2512
Changelog Entry
Fixes #2512. Adds check to ensure Adaptive Card's content is an Object, by @tdurnford in PR #25XX
Description
In the
AdaptiveCardAttachement, we pass the card content to Adaptive Card's parse function to create the card. If the content is not an Object, Adaptive Cards is supposed to push an error onto theerrorsarray. This works fine in Chrome; however, in IE 11, the browser throws an 'argument is not object' error since theObject.keysmethod is expecting an object and we are passing something that is not an object. As a temporary workaround, I added a check in theAdaptiveCardAttachementcomponent to make sure the Adaptive Card content is an object before parsing the card.