Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Card host config should generate from a merged style options #2566

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 6, 2019

Fixes #2565.

Changelog Entry

Fixed

  • Fixes #2565. Fixed Adaptive Card host config should generate from style options with default options merged, by @compulim in PR #2566

Description

(Copied from bug)

When we are creating Adaptive Cards host config, we are not using a default-merged style options.

If the dev did not specify style options, we show the card title in #000 color (inherited from default style options).

But if the dev specify style options of { richCardWrapTitle: true }, we show the card title in #333 color. This is because we did not merge default style options before creating a new Adaptive Cards host config. Thus, we are not using #000 as specified in default style options. Instead, we are using #333, which is the default value for Adaptive Cards host config.

Specific Changes

  • Update FullReactWebChat.js
    • When we create Adaptive Cards Host Config, we are creating it out of styleSet.options, instead of props.styleOptions

  • Testing Added
    • Existing tests is updated to cover the issue

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 63.324% when pulling 53037b9 on compulim:fix-2565 into c2d2395 on microsoft:master.

@compulim compulim merged commit c4a5852 into microsoft:master Nov 6, 2019
@compulim compulim deleted the fix-2565 branch November 6, 2019 23:42
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive Cards do not inherit style options properly
3 participants