Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version number to burn correctly under Ubuntu #2525

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Fix version number to burn correctly under Ubuntu #2525

merged 3 commits into from
Oct 31, 2019

Conversation

compulim
Copy link
Contributor

Fixes #2524.

Changelog Entry

Description

Version number burnt into the source code was undefined when building under Ubuntu, but works on Windows.

Specific Changes

  • Change all instances of NPM_PACKAGE_VERSION to npm_package_version
  • Testing Added
    • Manual tests are sufficient in release checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.345% when pulling d62e511 on test-version into 11332a8 on master.

@compulim compulim mentioned this pull request Oct 31, 2019
Closed
55 tasks
@compulim
Copy link
Contributor Author

Please ignore the build break for "[Experimental]" pipeline.

@corinagum corinagum merged commit dd80827 into master Oct 31, 2019
@compulim compulim deleted the test-version branch October 31, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output build should have correct version number burnt
3 participants
@compulim @coveralls @corinagum