Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample 13 for wrong Speech Services region #2482

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Fix sample 13 for wrong Speech Services region #2482

merged 4 commits into from
Oct 21, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 18, 2019 •
edited
Loading

Fixes #2473.

Changelog Entry

Fixed

  • Fix #2473. Fix samples 13 using wrong region for Speech Services credentials, by @compulim in PR #2482

Description

Sample 13 is not working because we recently changed Speech Services region from westus to westus2.

Specific Changes

  • Update fetch token logic to become fetch credentials logic, which include both region and token
  • When initializing, we will use the freshly-fetched region
    • We assume the region will not be changed once it's fetched
  • Testing Added
    • Currently, we don't have tests for samples

@corinagum
Copy link
Contributor

Still failing: https://webchattest.blob.core.windows.net/travis-result/2019/10/18/c654q/__image_snapshots__/chrome-docker/__diff_output__/rich-cards-js-audio-card-1-diff.png

@corinagum corinagum merged commit 3cf5d9b into master Oct 21, 2019
@compulim compulim deleted the fix-2473 branch October 22, 2019 18:43
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo 13 'customization-speech-ui' is broken
2 participants
@compulim @corinagum