Fix aria-label of Sendbox #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
Sep 23, 2019
…hat into emulator1823
compulim
reviewed
Sep 24, 2019
CHANGELOG.md
Outdated
| @@ -87,6 +87,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| - Fix [#2365](https://github.com/microsoft/BotFramework-WebChat/issues/2365). Fix Adaptive Card `pushButton` appearance on Chrome, by [@corinagum](https://github.com/corinagum) in PR [#2382](https://github.com/microsoft/BotFramework-WebChat/pull/2382) | |||
| - Fix [#2379](https://github.com/microsoft/BotFramework-WebChat/issues/2379). Speech synthesis can be configured off by passing `null`, by [@compulim](https://github.com/compulim) in PR [#2408](https://github.com/microsoft/BotFramework-WebChat/pull/2408) | |||
| - Fix [#2418](https://github.com/microsoft/BotFramework-WebChat/issues/2418). Connectivity status should not waste-render every 400 ms, by [@compulim](https://github.com/compulim) in PR [#2419](https://github.com/microsoft/BotFramework-WebChat/pull/2419) | |||
| - Fix [Emulator1823](https://github.com/microsoft/BotFramework-Emulator/issues/1823). Fix Sendbox "Type your message" being read twice by AT, by [@corinagum](https://github.com/corinagum) in PR [#2423](https://github.com/microsoft/BotFramework-WebChat/pull/2423) | |||
compulim
approved these changes
Sep 24, 2019
tdurnford
reviewed
Sep 24, 2019
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
tdurnford
reviewed
Sep 24, 2019
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
compulim
pushed a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Oct 5, 2019
* Fix aria-label of Sendbox * Edit CHANGELOG.md * Add localization * Update CHANGELOG.md Co-Authored-By: TJ Durnford <tjdford@gmail.com> * Update CHANGELOG.md Co-Authored-By: TJ Durnford <tjdford@gmail.com>
This was referenced Oct 5, 2019
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/BotFramework-Emulator#1823
Changelog Entry
Description
This is an accessibility fix for the sendbox in Web Chat, where the narrator was reading the placeholder twice. Now it will say, "Sendbox edit 'Type your message'" instead of "Type your message edit type your message"