Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new emitTypingIndicator action #2413

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Add new emitTypingIndicator action #2413

merged 7 commits into from
Sep 25, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 21, 2019 •
edited
Loading

Fixes #2157.

Changelog Entry

Description

Add a new emitTypingIndicator. This will complete the set of sendMessage, sendEvent, sendFiles, sendPostBack, sendMessageBack`.

We name it emit instead of send because of a name conflict. As typing indicator is very lightweight when compare to other activities, we think it is okay to make this exception to use emit for typing indicator.

Specific Changes

  • Added a new action, emitTypingIndicator
  • Added a saga, emitTypingIndicatorToPostActivitySaga
  • Modified existing sage to use the new action, instead of posting activity
  • Testing Added
    • No new tests are added, existing tests are enough to test this change

@coveralls
Copy link

coveralls commented Sep 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 65.386% when pulling 76fce74 on compulim:fix-2157 into a312e1c on microsoft:master.

tdurnford
tdurnford approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 2de5ecd into microsoft:master Sep 25, 2019
@compulim compulim deleted the fix-2157 branch September 25, 2019 03:15
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new sendTypingIndicator action dispatcher
3 participants
@compulim @coveralls @tdurnford