Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to select voice #2338

Merged
merged 11 commits into from
Aug 23, 2019
Merged

Add option to select voice #2338

merged 11 commits into from
Aug 23, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Aug 20, 2019 •
edited
Loading

Fixes #2292.

Changelog Entry

Added

Samples

Description

Add an option to select speech synthesis voice based on activity.

Specific Changes

  • Added an option selectVoice(voices: SpeechSynthesisVoice[], activity: Activity to select voice based on activity
  • Added a new sample to show how to select voice
  • Testing Added

@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 66.544% when pulling dcb1ec6 on compulim:fix-2292 into 19d25b7 on microsoft:master.

corinagum
corinagum approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending edits, but please wait until the 'Hooked' App.js is in! After that your App.js changes will need to be updated xD

samples/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
__tests__/speech.selectVoice.js Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/component/src/defaultSelectVoice.js Outdated Show resolved Hide resolved
samples/06.g.select-voice/README.md Outdated Show resolved Hide resolved
samples/06.g.select-voice/README.md Outdated Show resolved Hide resolved
samples/06.g.select-voice/README.md Outdated Show resolved Hide resolved
samples/06.g.select-voice/README.md Outdated Show resolved Hide resolved
@compulim compulim changed the title Add option to select voice [DON'T MERGE YET] Add option to select voice Aug 22, 2019
@compulim compulim changed the title [DON'T MERGE YET] Add option to select voice Add option to select voice Aug 22, 2019
@compulim compulim merged commit eb2a555 into microsoft:master Aug 23, 2019
@compulim compulim mentioned this pull request Oct 4, 2019
Closed
13 tasks
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select voice based on gender or content of activity
3 participants
@compulim @coveralls @corinagum